Hygiene from banner validation: missing-ledger guard + drift line dedup #49
Loading…
Reference in a new issue
No description provided.
Delete branch "oss-oo/zdo-banner-hygiene"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Two findings from the v1.24.0 banner validation fixture:
dispatch_strip()iterated the lifecycle ledger without a None guard — withstream-dispatches.jsonabsent (observatory installed before any dispatch ran)/api/sessionsanswered 500. The station never saw it (the ledger always exists there); the banner fixture instance pointed at an empty config dir and crashed. Guarded (or []) + regression test through the REAL_read_json_filepath (missing file).CLI 0.17.0 · CLI 0.16.9 → 0.17.0) — now a singleCLI <from> → <to>(plain version when no drift).Unittest 36/36 green; pinned Super-Linter slim v8.7.0 EXIT 0 (all six lanes).
dispatch_strip() crashed on a MISSING stream-dispatches.json (fresh install, no dispatch yet — _read_json_file returns None and the id-set comprehension iterated it; /api/sessions answered 500). Found by the banner validation fixture instance, which pointed the observatory at an empty config dir. Guarded + regression-tested through the real reader path. Banner meta line deduplicated the version ('CLI 0.17.0 · CLI 0.16.9 → 0.17.0' → 'CLI 0.16.9 → 0.17.0').