Remove the dead history submenu path (1.0.3) #12

Merged

claude merged 2 commits from oss-oo/no-dead-leaves into main

2026-10-27 13:30:32 +00:00

claude agent commented

2026-10-27 13:29:37 +00:00

Member

Removes the history submenu path that no build has filled since 0.1.0. The owner asked for this after the 1.0.2 review. No visible change.

applet.js, removed:
- the close/restore loop around _rebuildMenu;
- _openActiveSparkHistory;
- the leaf width forcing, and with it _clearForcedActorWidth;
- the leafLimit fold limit;
- the never-called _syncPopupRightInsets with the nested/expanded variants of _activityChartStyle;
- the _popupRightInsetRows list, the unread _usageOwnerMenu marker and the POPUP_NESTED_* / POPUP_EXPANDED_RIGHT_INSET constants.
Charts now get their constant inset style (padding-left: 10px; padding-right: 39px, the same as before) when they are created. Comments that spoke of leaves are reworded.
Tests: test-popup-width.js exercises the width lock a rebuild ends with instead of the dead sync. check-source.js checks that a chart gets its style before registration and keeps the removed names from coming back. Stubs of the dead fields are gone.
tests/ui/capture-variant.sh: the history variant's leaf openers are gone; they always returned {opened:0}. The scrolls stay.

Validation:

make verify is green (96 Python tests, all CJS suites) and Prettier is clean.
Isolated captures: usage-menu and usage-menu-history verified, and the model-visibility QA passes. Layout and size match the 1.0.2 README capture.
- One capture showed the Extra usage row ellipsized. Two reruns showed it in full, so it was a capture-timing flake in the credits fit, which this diff does not touch.
Independent review: "ship it", no blockers.
- It ran the old and new _rebuildMenu through seven scenarios, and the call order was identical in each.
- It confirmed that the chart style is unchanged.
- Its minor finding (_clearForcedActorWidth was dead) and its nits are fixed in 8a025d7.
A guard mutant that re-adds _historySubmenus is caught by check-source.js.

🤖 Generated with Claude Code

Removes the history submenu path that no build has filled since 0.1.0. The owner asked for this after the 1.0.2 review. **No visible change.** - **`applet.js`, removed:** - the close/restore loop around `_rebuildMenu`; - `_openActiveSparkHistory`; - the leaf width forcing, and with it `_clearForcedActorWidth`; - the `leafLimit` fold limit; - the never-called `_syncPopupRightInsets` with the nested/expanded variants of `_activityChartStyle`; - the `_popupRightInsetRows` list, the unread `_usageOwnerMenu` marker and the `POPUP_NESTED_*` / `POPUP_EXPANDED_RIGHT_INSET` constants. Charts now get their constant inset style (`padding-left: 10px; padding-right: 39px`, the same as before) when they are created. Comments that spoke of leaves are reworded. - **Tests:** `test-popup-width.js` exercises the width lock a rebuild ends with instead of the dead sync. `check-source.js` checks that a chart gets its style before registration and keeps the removed names from coming back. Stubs of the dead fields are gone. - **`tests/ui/capture-variant.sh`:** the history variant's leaf openers are gone; they always returned `{opened:0}`. The scrolls stay. Validation: - `make verify` is green (96 Python tests, all CJS suites) and Prettier is clean. - Isolated captures: `usage-menu` and `usage-menu-history` verified, and the model-visibility QA passes. Layout and size match the 1.0.2 README capture. - One capture showed the Extra usage row ellipsized. Two reruns showed it in full, so it was a capture-timing flake in the credits fit, which this diff does not touch. - Independent review: "ship it", no blockers. - It ran the old and new `_rebuildMenu` through seven scenarios, and the call order was identical in each. - It confirmed that the chart style is unchanged. - Its minor finding (`_clearForcedActorWidth` was dead) and its nits are fixed in 8a025d7. - A guard mutant that re-adds `_historySubmenus` is caught by `check-source.js`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude agent added 2 commits

2026-10-27 13:29:37 +00:00

Remove the dead history submenu path (1.0.3) 3e1dc798fe

No build has filled _historySubmenus since 0.1.0. Gone: the close/restore
loop around rebuilds, _openActiveSparkHistory, the leaf width forcing and
fold limit, the never-called _syncPopupRightInsets with its nested chart
styles and inset list, the unused _usageOwnerMenu marker and constants,
and the capture script's leaf openers. Charts get their constant inset
style at creation; the popup-width test now drives the real rebuild layout
pass. No visible change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Review nits for 1.0.3: the last dead helper, honest guards

Checks / Functional checks (pull_request) Successful in 33s

Details Explain this check

8a025d7fc5

- _clearForcedActorWidth lost its only callers with the leaf loops: gone.
- check-source.js keeps _historySubmenus, _openActiveSparkHistory and
  _syncPopupRightInsets from creeping back (the old instance-field half of
  the visibility assertion could never fail).
- The popup-width test says what it exercises: the width lock (the height
  clamp is a no-op without a monitor in the harness).
- Two comments reworded, one overlong comment line rewrapped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude agent merged commit b5aecc7e3b into main

2026-10-27 13:30:32 +00:00

claude agent deleted branch oss-oo/no-dead-leaves

2026-10-27 13:30:33 +00:00

claude agent referenced this pull request from a commit

2026-10-27 13:30:33 +00:00

Remove the dead history submenu path (1.0.3) (#12)

claude agent referenced this pull request

2026-10-27 13:31:38 +00:00

Release receipt: 1.0.3 #13