Fold in the independent review before v0.1.0 #1

Merged

claude merged 1 commit from oss-oo/review-v0.1.0 into main

2026-10-27 16:55:25 +00:00

claude agent commented

2026-10-27 16:54:22 +00:00

Member

Independent read-only review (subagent, 2026-10-27 17:40–17:51): one blocking finding (the CI unit check cannot pass in the container), seven should-fix items, nine nits. This PR folds in the blocker, S1–S4, S6, S7 and the nits in this repository; S4/S5 on the launcher hook land in the owner's dotfiles. Verified on the station: clients and helper compile, install.sh reinstalls and oo-appserver doctor reports no findings with the app attached.

🤖 Generated with Claude Code

Independent read-only review (subagent, 2026-10-27 17:40–17:51): one blocking finding (the CI unit check cannot pass in the container), seven should-fix items, nine nits. This PR folds in the blocker, S1–S4, S6, S7 and the nits in this repository; S4/S5 on the launcher hook land in the owner's dotfiles. Verified on the station: clients and helper compile, `install.sh` reinstalls and `oo-appserver doctor` reports no findings with the app attached. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude agent added 1 commit

2026-10-27 16:54:22 +00:00

Fold in the independent review before v0.1.0

ci / check (pull_request) Successful in 7s

Details Explain this check

f40667b5b8

- CI: the unit check installs a stub at the bundle path and sets XDG_RUNTIME_DIR
  (systemd-analyze verify checks Exec* executables; the container has no bundle)
- turn client: steer receipts carry the turn id; notifications of other threads are
  ignored (never another chat's text in a receipt); receipts 0600 in a 0700 dir;
  refusals (unknown thread, no active turn, JSON-RPC error) get a receipt class and a
  non-zero exit; explicit mode check; transport timeouts become clean errors
- probe client: transport timeouts become clean errors
- helper: doctor warns when the service predates the login's session environment
  (DISPLAY, SSH_AUTH_SOCK, …); probe failures are visible; readyz waits on a deadline;
  --help exits 0; logs without journalctl fails cleanly
- installer: VERSION marker in the target; unit-change hint; --target needs a value;
  readyz wait without curl
- repository avatar (ops beacon, CC BY-SA) under assets/ with attribution
- README: hook functions, knobs, exit codes, session-environment caveat, loopback note
  (any local user; Origin-bearing handshakes get 403), dotfiles convention

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

claude agent merged commit 584a499e31 into main

2026-10-27 16:55:25 +00:00

claude agent deleted branch oss-oo/review-v0.1.0

2026-10-27 16:55:25 +00:00

claude agent referenced this pull request from a commit

2026-10-27 16:55:27 +00:00

Fold in the independent review before v0.1.0 (#1)