Name the laboratory, not its upstream, on every public surface #161
Loading…
Reference in a new issue
No description provided.
Delete branch "oss-oo/lab-naming-public-surfaces"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Owner decision 2026-10-27 (Claudiu, in chat): the public face of oss-oo.io speaks of the laboratory — Labor, Laboratory, Laboratorium — and the name of the upstream software stays out of rendered texts and previews ("our origin, soon no longer recognisable"). Repositories that are literally about the upstream product (
forgejo-core,forgejo-patches) keep their names on the owner's word.What changes (rendered texts only, 8 files)
site/landing/index.html)site/agents/index.html)forgejo-custom/templates/custom/extra_links_footer.tmpl)site/legal/index.html)site/observatory/index.html,users.html)forgejo <version> · oss-oo.ioforge core <version before the "+" build suffix> · oss-oo.iodocs/RUNBOOK.mdfooter rowUnchanged on purpose
FORGEJO_TOKEN(agents page, it is the gateway's env var), compose service names,FORGEJO__…env keys,.forgejo/,forgejo-custom/,tests/fixtures/forgejo-head-upstream.tmpl.forgejo-custom/templates/base/UPSTREAM-NOTICE.md,docs/third-party/forgejo-LICENSE.txtand thehead.tmplattribution comment — license attribution stays exactly as it is (the footer link was never a legal notice; the stock "powered by" line is already off viaSHOW_FOOTER_POWERED_BY=false).Independent review (read-only subagent, no credentials, 2026-10-27 16:05–16:15)
No blocking finding; verdict "mergeable as is". Folded in by
51384ad: the stale engine version in the chip (should-fix), the card title "CI gates" and the observatory version suffix (nits). Verified by the reviewer: footer hook is valid Go html/template with one<a>per line; HTML/UTF-8 intact; both observatory scripts passnode --check; sitemap parses; RUNBOOK row keeps two columns; no test, script or CI step depends on the old strings (tests/seo_templates_test.goasserts onhead.tmploutput and the landing JSON-LD only); license files untouched; dropping the external "powered by" link raises no GPLv3 attribution concern (no credit line is required, the stock footer credit was already off).Left for the house (needs the e2e gate, a separate PR, or a design decision)
compose.ymllines 35–37: the comment still quotes the old footer wording. Touchingcompose*.ymlrequiresscripts/e2e-local.sh(AGENTS.md), which I did not run — fold it into the next compose change.<meta name="author" content="Forgejo – Beyond coding. We forge.">and<meta name="keywords" content="git,forge,forgejo">from the stock[ui.meta]defaults —FORGEJO__ui_0X2E_meta__AUTHOR/…__KEYWORDSin compose (uppercase X, the spelling the repo documents) would replace them; same gate.README.mdprose (lines 18, 59; the component table rows 24 and 27 name the actual software, which may be wanted in a recipe): the footer link now lands on this repository, whose README names the upstream in its first screen — a separate small PR, no gate./api/swaggeris the stock swagger UI titled "Forgejo API" (linked from the agents page) — aforgejo-custom/templates/swagger/ui.tmploverride would be the follow-up.forgejo-custom/public/assets/img/BRANDING.mdis an operator note served publicly at/assets/img/BRANDING.mdand names the upstream — moving it out ofpublic/(e.g.docs/) needs no gate.OSS-OO/laboratorynow reads "… Forge core, CI runner, MCP agent gateway …"; topics in both orgs carry no upstream name.Verification
/2 hits (the chips),/agents/3 (two prose, one env var),/legal/1 sentence,/user/loginfooter link + the two meta tags — confirmed independently by the reviewer; this PR removes every rendered prose hit undersite/and the footer link.go; the SEO test runs in CI only. CI on21952ae:ci / ciandaccess-validation-contract / contractboth green; CI on51384ad: see the checks.🤖 Generated with Claude Code